Skip to content
Snippets Groups Projects
Commit ddc0e819 authored by deep1401's avatar deep1401
Browse files

Fix for setting selected dataset on editing evals

parent d4447b16
No related branches found
No related tags found
No related merge requests found
...@@ -130,14 +130,17 @@ export default function EvalModal({ ...@@ -130,14 +130,17 @@ export default function EvalModal({
).some((key) => key.toLowerCase().includes('dataset')); ).some((key) => key.toLowerCase().includes('dataset'));
setHasDatasetKey(datasetKeyExists); setHasDatasetKey(datasetKeyExists);
if ( if (
evalConfig.script_parameters.dataset_display_message && evalConfig.script_parameters._dataset_display_message &&
evalConfig.script_parameters.dataset_display_message.length > evalConfig.script_parameters._dataset_display_message.length >
0 0
) { ) {
setDatasetDisplayMessage( setDatasetDisplayMessage(
evalConfig.script_parameters.dataset_display_message evalConfig.script_parameters._dataset_display_message
); );
} }
if (hasDatasetKey && evalConfig.script_parameters.dataset_name.length > 0) {
setSelectedDataset(evalConfig.script_parameters.dataset_name);
}
} }
setNameInput(evalConfig?.name); setNameInput(evalConfig?.name);
if (!nameInput && evalConfig?.script_parameters.run_name) { if (!nameInput && evalConfig?.script_parameters.run_name) {
...@@ -162,14 +165,14 @@ export default function EvalModal({ ...@@ -162,14 +165,14 @@ export default function EvalModal({
value.default, value.default,
]) ])
); );
if (parsedData && parsedData.dataset) { if (parsedData && parsedData._dataset) {
setHasDatasetKey(true); setHasDatasetKey(true);
// Check if the dataset display message string length is greater than 0 // Check if the dataset display message string length is greater than 0
if ( if (
parsedData.dataset_display_message && parsedData._dataset_display_message &&
parsedData.dataset_display_message.length > 0 parsedData._dataset_display_message.length > 0
) { ) {
setDatasetDisplayMessage(parsedData.dataset_display_message); setDatasetDisplayMessage(parsedData._dataset_display_message);
// Add dataset display message to the config parameters // Add dataset display message to the config parameters
} }
} }
...@@ -246,7 +249,7 @@ export default function EvalModal({ ...@@ -246,7 +249,7 @@ export default function EvalModal({
const formJson = Object.fromEntries((formData as any).entries()); const formJson = Object.fromEntries((formData as any).entries());
// Add an extra field in formJson for datasetDisplayMessage // Add an extra field in formJson for datasetDisplayMessage
if (datasetDisplayMessage.length > 0) { if (datasetDisplayMessage.length > 0) {
formJson.dataset_display_message = datasetDisplayMessage; formJson._dataset_display_message = datasetDisplayMessage;
} }
try { try {
if (!formJson.run_name) { if (!formJson.run_name) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment