From ddc0e81976fbe4dfd7fd28254eae203d15d2523d Mon Sep 17 00:00:00 2001
From: deep1401 <gandhi0869@gmail.com>
Date: Mon, 10 Feb 2025 09:33:04 -0800
Subject: [PATCH] Fix for setting selected dataset on editing evals
---
.../components/Experiment/Eval/EvalModal.tsx | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/renderer/components/Experiment/Eval/EvalModal.tsx b/src/renderer/components/Experiment/Eval/EvalModal.tsx
index 35aa62b1..6c551075 100644
--- a/src/renderer/components/Experiment/Eval/EvalModal.tsx
+++ b/src/renderer/components/Experiment/Eval/EvalModal.tsx
@@ -130,14 +130,17 @@ export default function EvalModal({
).some((key) => key.toLowerCase().includes('dataset'));
setHasDatasetKey(datasetKeyExists);
if (
- evalConfig.script_parameters.dataset_display_message &&
- evalConfig.script_parameters.dataset_display_message.length >
+ evalConfig.script_parameters._dataset_display_message &&
+ evalConfig.script_parameters._dataset_display_message.length >
0
) {
setDatasetDisplayMessage(
- evalConfig.script_parameters.dataset_display_message
+ evalConfig.script_parameters._dataset_display_message
);
}
+ if (hasDatasetKey && evalConfig.script_parameters.dataset_name.length > 0) {
+ setSelectedDataset(evalConfig.script_parameters.dataset_name);
+ }
}
setNameInput(evalConfig?.name);
if (!nameInput && evalConfig?.script_parameters.run_name) {
@@ -162,14 +165,14 @@ export default function EvalModal({
value.default,
])
);
- if (parsedData && parsedData.dataset) {
+ if (parsedData && parsedData._dataset) {
setHasDatasetKey(true);
// Check if the dataset display message string length is greater than 0
if (
- parsedData.dataset_display_message &&
- parsedData.dataset_display_message.length > 0
+ parsedData._dataset_display_message &&
+ parsedData._dataset_display_message.length > 0
) {
- setDatasetDisplayMessage(parsedData.dataset_display_message);
+ setDatasetDisplayMessage(parsedData._dataset_display_message);
// Add dataset display message to the config parameters
}
}
@@ -246,7 +249,7 @@ export default function EvalModal({
const formJson = Object.fromEntries((formData as any).entries());
// Add an extra field in formJson for datasetDisplayMessage
if (datasetDisplayMessage.length > 0) {
- formJson.dataset_display_message = datasetDisplayMessage;
+ formJson._dataset_display_message = datasetDisplayMessage;
}
try {
if (!formJson.run_name) {
--
GitLab