Skip to content
Snippets Groups Projects
Unverified Commit 6cd92aff authored by Logan's avatar Logan Committed by GitHub
Browse files

fix obj insert_nodes (#11836)

parent 84904839
No related branches found
No related tags found
Loading
...@@ -217,6 +217,14 @@ class BaseIndex(Generic[IS], ABC): ...@@ -217,6 +217,14 @@ class BaseIndex(Generic[IS], ABC):
def insert_nodes(self, nodes: Sequence[BaseNode], **insert_kwargs: Any) -> None: def insert_nodes(self, nodes: Sequence[BaseNode], **insert_kwargs: Any) -> None:
"""Insert nodes.""" """Insert nodes."""
for node in nodes:
if isinstance(node, IndexNode):
try:
node.dict()
except ValueError:
self._object_map[node.index_id] = node.obj
node.obj = None
with self._callback_manager.as_trace("insert_nodes"): with self._callback_manager.as_trace("insert_nodes"):
self.docstore.add_documents(nodes, allow_update=True) self.docstore.add_documents(nodes, allow_update=True)
self._insert(nodes, **insert_kwargs) self._insert(nodes, **insert_kwargs)
......
...@@ -317,6 +317,14 @@ class VectorStoreIndex(BaseIndex[IndexDict]): ...@@ -317,6 +317,14 @@ class VectorStoreIndex(BaseIndex[IndexDict]):
VectorStoreIndex only stores nodes in document store VectorStoreIndex only stores nodes in document store
if vector store does not store text if vector store does not store text
""" """
for node in nodes:
if isinstance(node, IndexNode):
try:
node.dict()
except ValueError:
self._object_map[node.index_id] = node.obj
node.obj = None
self._insert(nodes, **insert_kwargs) self._insert(nodes, **insert_kwargs)
self._storage_context.index_store.add_index_struct(self._index_struct) self._storage_context.index_store.add_index_struct(self._index_struct)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment