From 6cd92affa5835aa21f823ff985a81f006c496bbd Mon Sep 17 00:00:00 2001
From: Logan <logan.markewich@live.com>
Date: Mon, 11 Mar 2024 21:21:17 -0600
Subject: [PATCH] fix obj insert_nodes (#11836)
---
llama-index-core/llama_index/core/indices/base.py | 8 ++++++++
.../llama_index/core/indices/vector_store/base.py | 8 ++++++++
2 files changed, 16 insertions(+)
diff --git a/llama-index-core/llama_index/core/indices/base.py b/llama-index-core/llama_index/core/indices/base.py
index a35797a4a1..08c0b3b133 100644
--- a/llama-index-core/llama_index/core/indices/base.py
+++ b/llama-index-core/llama_index/core/indices/base.py
@@ -217,6 +217,14 @@ class BaseIndex(Generic[IS], ABC):
def insert_nodes(self, nodes: Sequence[BaseNode], **insert_kwargs: Any) -> None:
"""Insert nodes."""
+ for node in nodes:
+ if isinstance(node, IndexNode):
+ try:
+ node.dict()
+ except ValueError:
+ self._object_map[node.index_id] = node.obj
+ node.obj = None
+
with self._callback_manager.as_trace("insert_nodes"):
self.docstore.add_documents(nodes, allow_update=True)
self._insert(nodes, **insert_kwargs)
diff --git a/llama-index-core/llama_index/core/indices/vector_store/base.py b/llama-index-core/llama_index/core/indices/vector_store/base.py
index 474169b677..596cf50d02 100644
--- a/llama-index-core/llama_index/core/indices/vector_store/base.py
+++ b/llama-index-core/llama_index/core/indices/vector_store/base.py
@@ -317,6 +317,14 @@ class VectorStoreIndex(BaseIndex[IndexDict]):
VectorStoreIndex only stores nodes in document store
if vector store does not store text
"""
+ for node in nodes:
+ if isinstance(node, IndexNode):
+ try:
+ node.dict()
+ except ValueError:
+ self._object_map[node.index_id] = node.obj
+ node.obj = None
+
self._insert(nodes, **insert_kwargs)
self._storage_context.index_store.add_index_struct(self._index_struct)
--
GitLab