Skip to content
Snippets Groups Projects
Unverified Commit eb3245b1 authored by James Briggs's avatar James Briggs Committed by GitHub
Browse files

Merge branch 'main' into zahid/semantic_router_fix

parents 4e13e2a7 a4aa3f21
No related branches found
No related tags found
No related merge requests found
...@@ -11,11 +11,11 @@ Please follow these guidelines when making a contribution: ...@@ -11,11 +11,11 @@ Please follow these guidelines when making a contribution:
- Ensure that the Pull Request title is prepended with a [valid type](https://flank.github.io/flank/pr_titles/). E.g. `feat: My New Feature`. - Ensure that the Pull Request title is prepended with a [valid type](https://flank.github.io/flank/pr_titles/). E.g. `feat: My New Feature`.
- Run linting (and fix any issues that are flagged) by: - Run linting (and fix any issues that are flagged) by:
- Navigating to /semantic-router. - Navigating to /semantic-router.
- Running `poetry run make lint` to fix linting issues. - Running `make lint` to fix linting issues.
- Running `poetry run black .` to fix `black` linting issues. - Running `black .` to fix `black` linting issues.
- Running `poetry run ruff . --fix` to fix `ruff` linting issues (where possible, others may need manual changes). - Running `ruff . --fix` to fix `ruff` linting issues (where possible, others may need manual changes).
- Confirming the linters pass using `poetry run make lint` again. - Running `mypy .` and then fixing any of the issues that are raised.
- Running `ruff . --fix`. - Confirming the linters pass using `make lint` again.
- Ensure that, for any new code, new [PyTests are written](https://github.com/aurelio-labs/semantic-router/tree/main/tests/unit). If any code is removed, then ensure that corresponding PyTests are also removed. Finally, ensure that all remaining PyTests pass using `pytest ./tests` (to avoid integration tests you can run `pytest ./tests/unit`. - Ensure that, for any new code, new [PyTests are written](https://github.com/aurelio-labs/semantic-router/tree/main/tests/unit). If any code is removed, then ensure that corresponding PyTests are also removed. Finally, ensure that all remaining PyTests pass using `pytest ./tests` (to avoid integration tests you can run `pytest ./tests/unit`.
- Codecov checks will inform you if any code is not covered by PyTests upon creating the PR. You should aim to cover new code with PyTests. - Codecov checks will inform you if any code is not covered by PyTests upon creating the PR. You should aim to cover new code with PyTests.
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment