Merge pull request #25 from smallstep/mariano/lint

Fix linter errors

Makefile

@@ -47,12 +47,16 @@ race:
 fmt:
 	$Q goimports -local github.com/golangci/golangci-lint -l -w $(SRC)
 
-lint: SHELL:=/bin/bash
-lint:
+lint: golint govulncheck
+
+golint: SHELL:=/bin/bash
+golint:
 	$Q LOG_LEVEL=error golangci-lint run --config <(curl -s https://raw.githubusercontent.com/smallstep/workflows/master/.golangci.yml) --timeout=30m
+
+govulncheck:
 	$Q govulncheck ./...
 
-.PHONY: fmt lint
+.PHONY: fmt lint golint govulncheck
 
 #########################################
 # Clean

truststore_darwin.go

@@ -122,7 +122,7 @@ func installPlatform(filename string, cert *x509.Certificate) error {
 	return nil
 }
 
-func uninstallPlatform(filename string, cert *x509.Certificate) error {
+func uninstallPlatform(filename string, _ *x509.Certificate) error {
 	cmd := exec.Command("sudo", "security", "remove-trusted-cert", "-d", filename)
 	out, err := cmd.CombinedOutput()
 	if err != nil {

truststore_java.go

@@ -87,7 +87,7 @@ func (t *JavaTrust) Install(filename string, cert *x509.Certificate) error {
 }
 
 // Uninstall implements the Trust interface.
-func (t *JavaTrust) Uninstall(filename string, cert *x509.Certificate) error {
+func (t *JavaTrust) Uninstall(_ string, cert *x509.Certificate) error {
 	args := []string{
 		"-delete",
 		"-alias", uniqueName(cert),

truststore_linux.go

@@ -82,7 +82,7 @@ func installPlatform(filename string, cert *x509.Certificate) error {
 	return nil
 }
 
-func uninstallPlatform(filename string, cert *x509.Certificate) error {
+func uninstallPlatform(_ string, cert *x509.Certificate) error {
 	if SystemTrustCommand == nil {
 		return ErrNotSupported
 	}

truststore_nss.go

@@ -80,7 +80,7 @@ func (t *NSSTrust) Install(filename string, cert *x509.Certificate) error {
 }
 
 // Uninstall implements the Trust interface.
-func (t *NSSTrust) Uninstall(filename string, cert *x509.Certificate) (err error) {
+func (t *NSSTrust) Uninstall(_ string, cert *x509.Certificate) (err error) {
 	forEachNSSProfile(func(profile string) {
 		if err != nil {
 			return

truststore_others.go

+//go:build !linux && !darwin && !windows && !freebsd
 // +build !linux,!darwin,!windows,!freebsd
 
 package truststore
@@ -12,10 +13,10 @@ var (
 	CertutilInstallHelp = ""
 )
 
-func installPlatform(filename string, cert *x509.Certificate) error {
+func installPlatform(string, *x509.Certificate) error {
 	return ErrTrustNotSupported
 }
 
-func uninstallPlatform(filename string, cert *x509.Certificate) error {
+func uninstallPlatform(string, *x509.Certificate) error {
 	return ErrTrustNotSupported
 }