Skip to content
Snippets Groups Projects
Unverified Commit aaff02bc authored by yisding's avatar yisding Committed by GitHub
Browse files

Merge pull request #48 from ysak-y/modify_bug_of_vector_store_index

[BUG FIX] Use retriever from argument if exist in asQueryEngine of VectorStoreIndex
parents 2726e375 34f5398f
No related branches found
No related tags found
No related merge requests found
...@@ -20,11 +20,11 @@ import { ...@@ -20,11 +20,11 @@ import {
IndexDict, IndexDict,
VectorIndexConstructorProps, VectorIndexConstructorProps,
VectorIndexOptions, VectorIndexOptions,
IndexStructType
} from "../BaseIndex"; } from "../BaseIndex";
import { BaseRetriever } from "../../Retriever"; import { BaseRetriever } from "../../Retriever";
import { ResponseSynthesizer } from "../../ResponseSynthesizer"; import { ResponseSynthesizer } from "../../ResponseSynthesizer";
import { BaseDocumentStore } from "../../storage/docStore/types"; import { BaseDocumentStore } from "../../storage/docStore/types";
import { IndexStructType } from "../BaseIndex";
/** /**
* The VectorStoreIndex, an index that stores the nodes only according to their vector embedings. * The VectorStoreIndex, an index that stores the nodes only according to their vector embedings.
...@@ -216,9 +216,7 @@ export class VectorStoreIndex extends BaseIndex<IndexDict> { ...@@ -216,9 +216,7 @@ export class VectorStoreIndex extends BaseIndex<IndexDict> {
retriever?: BaseRetriever; retriever?: BaseRetriever;
responseSynthesizer?: ResponseSynthesizer; responseSynthesizer?: ResponseSynthesizer;
}): BaseQueryEngine { }): BaseQueryEngine {
let { retriever, responseSynthesizer } = options ?? {}; const { retriever, responseSynthesizer } = options ?? {};
return new RetrieverQueryEngine(retriever ?? this.asRetriever(), responseSynthesizer);
retriever = retriever ?? this.asRetriever();
return new RetrieverQueryEngine(this.asRetriever(), responseSynthesizer);
} }
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment