Skip to content
Snippets Groups Projects
Commit 444edd16 authored by Mateusz Charytoniuk's avatar Mateusz Charytoniuk
Browse files

fix(github-workflow)?: do not start coroutine loops manuall

parent d1f89a7d
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
src/ObservableTaskTableSlotStatusUpdateIteratorTest.php
+ 60
− 62
View file @ 444edd16
...@@ -12,65 +12,63 @@ use Swoole\Event; ...@@ -12,65 +12,63 @@ use Swoole\Event;
/** /**
* @internal * @internal
*/ */
// #[CoversClass(ObservableTaskTableSlotStatusUpdateIterator::class)] #[CoversClass(ObservableTaskTableSlotStatusUpdateIterator::class)]
// final class ObservableTaskTableSlotStatusUpdateIteratorTest extends TestCase final class ObservableTaskTableSlotStatusUpdateIteratorTest extends TestCase
// { {
// private ?ObservableTaskConfiguration $observableTaskConfiguration = null; private ?ObservableTaskConfiguration $observableTaskConfiguration = null;
// private ?ObservableTaskTable $observableTaskTable = null; private ?ObservableTaskTable $observableTaskTable = null;
// protected function setUp(): void protected function setUp(): void
// { {
// $this->observableTaskConfiguration = new ObservableTaskConfiguration( $this->observableTaskConfiguration = new ObservableTaskConfiguration(
// maxTasks: 4, maxTasks: 4,
// serializedStatusSize: 32768, serializedStatusSize: 32768,
// ); );
// $this->observableTaskTable = new ObservableTaskTable( $this->observableTaskTable = new ObservableTaskTable(
// observableTaskConfiguration: $this->observableTaskConfiguration, observableTaskConfiguration: $this->observableTaskConfiguration,
// serializer: new Vanilla(), serializer: new Vanilla(),
// ); );
// } }
// protected function tearDown(): void protected function tearDown(): void
// { {
// Event::wait(); Event::wait();
// } }
// public function test_channel_is_observed(): void public function test_channel_is_observed(): void
// { {
// SwooleCoroutineHelper::mustRun(function () { $observableTask = new ObservableTask(static function () {
// $observableTask = new ObservableTask(static function () { yield new ObservableTaskStatusUpdate(
// yield new ObservableTaskStatusUpdate( ObservableTaskStatus::Running,
// ObservableTaskStatus::Running, 'test1',
// 'test1', );
// );
yield new ObservableTaskStatusUpdate(
// yield new ObservableTaskStatusUpdate( ObservableTaskStatus::Finished,
// ObservableTaskStatus::Finished, 'test2',
// 'test2', );
// ); });
// });
SwooleCoroutineHelper::mustGo(function () {
// SwooleCoroutineHelper::mustGo(function () { self::assertNotNull($this->observableTaskTable);
// self::assertNotNull($this->observableTaskTable);
$iterator = new ObservableTaskTableSlotStatusUpdateIterator($this->observableTaskTable);
// $iterator = new ObservableTaskTableSlotStatusUpdateIterator($this->observableTaskTable);
foreach ($iterator as $statusUpdate) {
// foreach ($iterator as $statusUpdate) { self::assertInstanceOf(ObservableTaskSlotStatusUpdate::class, $statusUpdate);
// self::assertInstanceOf(ObservableTaskSlotStatusUpdate::class, $statusUpdate); self::assertEquals('0', $statusUpdate->slotId);
// self::assertEquals('0', $statusUpdate->slotId);
if (ObservableTaskStatus::Finished === $statusUpdate->observableTaskStatusUpdate->status) {
// if (ObservableTaskStatus::Finished === $statusUpdate->observableTaskStatusUpdate->status) { self::assertEquals('test2', $statusUpdate->observableTaskStatusUpdate->data);
// self::assertEquals('test2', $statusUpdate->observableTaskStatusUpdate->data);
break;
// break; }
// }
self::assertEquals('test1', $statusUpdate->observableTaskStatusUpdate->data);
// self::assertEquals('test1', $statusUpdate->observableTaskStatusUpdate->data); }
// } });
// });
$this->observableTaskTable?->observe($observableTask);
// $this->observableTaskTable?->observe($observableTask); }
// }); }
// }
// }
src/ObservableTaskTableTest.php
+ 31
− 33
View file @ 444edd16
...@@ -39,51 +39,49 @@ final class ObservableTaskTableTest extends TestCase ...@@ -39,51 +39,49 @@ final class ObservableTaskTableTest extends TestCase
Event::wait(); Event::wait();
} }
// public function test_channel_is_observed(): void public function test_channel_is_observed(): void
// { {
// SwooleCoroutineHelper::mustRun(function () { $channel = new Channel();
// $channel = new Channel(); $wg = new WaitGroup();
// $wg = new WaitGroup();
// $this->observableTaskTable?->observableChannels->add($channel); $this->observableTaskTable?->observableChannels->add($channel);
// $observableTask = new ObservableTask(static function () { $observableTask = new ObservableTask(static function () {
// yield new ObservableTaskStatusUpdate( yield new ObservableTaskStatusUpdate(
// ObservableTaskStatus::Running, ObservableTaskStatus::Running,
// 'test1', 'test1',
// ); );
// yield new ObservableTaskStatusUpdate( yield new ObservableTaskStatusUpdate(
// ObservableTaskStatus::Finished, ObservableTaskStatus::Finished,
// 'test2', 'test2',
// ); );
// }); });
// $wg->add(); $wg->add();
// SwooleCoroutineHelper::mustGo(static function () use ($channel, $wg) { SwooleCoroutineHelper::mustGo(static function () use ($channel, $wg) {
// Coroutine::defer(static function () use ($wg) { Coroutine::defer(static function () use ($wg) {
// $wg->done(); $wg->done();
// }); });
// $status1 = $channel->pop(); $status1 = $channel->pop();
// self::assertInstanceOf(ObservableTaskSlotStatusUpdate::class, $status1); self::assertInstanceOf(ObservableTaskSlotStatusUpdate::class, $status1);
// self::assertSame(ObservableTaskStatus::Running, $status1->observableTaskStatusUpdate->status); self::assertSame(ObservableTaskStatus::Running, $status1->observableTaskStatusUpdate->status);
// $status2 = $channel->pop(); $status2 = $channel->pop();
// self::assertInstanceOf(ObservableTaskSlotStatusUpdate::class, $status2); self::assertInstanceOf(ObservableTaskSlotStatusUpdate::class, $status2);
// self::assertSame(ObservableTaskStatus::Finished, $status2->observableTaskStatusUpdate->status); self::assertSame(ObservableTaskStatus::Finished, $status2->observableTaskStatusUpdate->status);
// }); });
// $this->observableTaskTable?->observe($observableTask); $this->observableTaskTable?->observe($observableTask);
// $wg->wait(); $wg->wait();
// $this->observableTaskTable?->observableChannels->remove($channel); $this->observableTaskTable?->observableChannels->remove($channel);
// }); }
// }
public function test_task_is_observed(): void public function test_task_is_observed(): void
{ {
......
src/SwooleTimeoutTest.php
+ 38
− 42
View file @ 444edd16
...@@ -11,45 +11,41 @@ use Swoole\Event; ...@@ -11,45 +11,41 @@ use Swoole\Event;
/** /**
* @internal * @internal
*/ */
// #[CoversClass(SwooleTimeout::class)] #[CoversClass(SwooleTimeout::class)]
// #[CoversClass(SwooleTimeoutScheduled::class)] #[CoversClass(SwooleTimeoutScheduled::class)]
// #[CoversClass(SwooleTimeoutScheduler::class)] #[CoversClass(SwooleTimeoutScheduler::class)]
// final class SwooleTimeoutTest extends TestCase final class SwooleTimeoutTest extends TestCase
// { {
// protected function tearDown(): void protected function tearDown(): void
// { {
// Event::wait(); Event::wait();
// } }
// public function test_code_executes_after_timeout(): void public function test_code_executes_after_timeout(): void
// { {
// SwooleCoroutineHelper::mustRun(static function () { $before = microtime(true);
// $before = microtime(true);
$timeout = new SwooleTimeout(static function () use ($before) {
// $timeout = new SwooleTimeout(static function () use ($before) { $after = microtime(true);
// $after = microtime(true);
self::assertGreaterThan(0.03, $after - $before);
// self::assertGreaterThan(0.03, $after - $before); self::assertLessThan(0.035, $after - $before);
// self::assertLessThan(0.035, $after - $before); });
// });
$timeout->setTimeout(0.03);
// $timeout->setTimeout(0.03); }
// });
// } public function test_task_is_rescheduled(): void
{
// public function test_task_is_rescheduled(): void $before = microtime(true);
// {
// SwooleCoroutineHelper::mustRun(static function () { $timeout = new SwooleTimeout(static function () use ($before) {
// $before = microtime(true); $after = microtime(true);
// $timeout = new SwooleTimeout(static function () use ($before) { self::assertGreaterThan(0.03, $after - $before);
// $after = microtime(true); self::assertLessThan(0.035, $after - $before);
});
// self::assertGreaterThan(0.03, $after - $before);
// self::assertLessThan(0.035, $after - $before); $timeout->setTimeout(0.02)->reschedule(0.03);
// }); }
}
// $timeout->setTimeout(0.02)->reschedule(0.03);
// });
// }
// }
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

:feet::heart: Strive to be the person your dogs believe you are :heart::feet: