Skip to content
Snippets Groups Projects
Unverified Commit 3df91cfb authored by Marc Mueller's avatar Marc Mueller Committed by GitHub
Browse files

Fix method subtyping [recorder] (#134212)

parent d3fab42c
No related branches found
No related tags found
No related merge requests found
...@@ -6,7 +6,7 @@ from collections.abc import Callable ...@@ -6,7 +6,7 @@ from collections.abc import Callable
from datetime import datetime, timedelta from datetime import datetime, timedelta
import logging import logging
import time import time
from typing import Any, Final, Self, cast from typing import Any, Final, Protocol, Self, cast
import ciso8601 import ciso8601
from fnv_hash_fast import fnv1a_32 from fnv_hash_fast import fnv1a_32
...@@ -233,10 +233,14 @@ CONTEXT_BINARY_TYPE = LargeBinary(CONTEXT_ID_BIN_MAX_LENGTH).with_variant( ...@@ -233,10 +233,14 @@ CONTEXT_BINARY_TYPE = LargeBinary(CONTEXT_ID_BIN_MAX_LENGTH).with_variant(
TIMESTAMP_TYPE = DOUBLE_TYPE TIMESTAMP_TYPE = DOUBLE_TYPE
class _LiteralProcessorType(Protocol):
def __call__(self, value: Any) -> str: ...
class JSONLiteral(JSON): class JSONLiteral(JSON):
"""Teach SA how to literalize json.""" """Teach SA how to literalize json."""
def literal_processor(self, dialect: Dialect) -> Callable[[Any], str]: def literal_processor(self, dialect: Dialect) -> _LiteralProcessorType:
"""Processor to convert a value to JSON.""" """Processor to convert a value to JSON."""
def process(value: Any) -> str: def process(value: Any) -> str:
......
...@@ -2453,7 +2453,7 @@ class BaseMigration(ABC): ...@@ -2453,7 +2453,7 @@ class BaseMigration(ABC):
self.migration_changes = migration_changes self.migration_changes = migration_changes
@abstractmethod @abstractmethod
def migrate_data(self, instance: Recorder) -> bool: def migrate_data(self, instance: Recorder, /) -> bool:
"""Migrate some data, return True if migration is completed.""" """Migrate some data, return True if migration is completed."""
def _migrate_data(self, instance: Recorder) -> bool: def _migrate_data(self, instance: Recorder) -> bool:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment