Skip to content
Snippets Groups Projects
  • J. Nick Koston's avatar
    ed0568c6
    Ensure config entries are not unloaded while their platforms are setting up (#118767) · ed0568c6
    J. Nick Koston authored
    * Report non-awaited/non-locked config entry platform forwards
    
    Its currently possible for config entries to be reloaded while their platforms
    are being forwarded if platform forwards are not awaited or done after the
    config entry is setup since the lock will not be held in this case.
    
    In https://developers.home-assistant.io/blog/2022/07/08/config_entry_forwards
    we advised to await platform forwards to ensure this does not happen, however
    for sleeping devices and late discovered devices, platform forwards may happen
    later.
    
    If config platform forwards are happening during setup, they should be awaited
    
    If config entry platform forwards are not happening during setup, instead
    async_late_forward_entry_setups should be used which will hold the lock to
    prevent the config entry from being unloaded while its platforms are being
    setup
    
    * Report non-awaited/non-locked config entry platform forwards
    
    Its currently possible for config entries to be reloaded while their platforms
    are being forwarded if platform forwards are not awaited or done after the
    config entry is setup since the lock will not be held in this case.
    
    In https://developers.home-assistant.io/blog/2022/07/08/config_entry_forwards
    we advised to await platform forwards to ensure this does not happen, however
    for sleeping devices and late discovered devices, platform forwards may happen
    later.
    
    If config platform forwards are happening during setup, they should be awaited
    
    If config entry platform forwards are not happening during setup, instead
    async_late_forward_entry_setups should be used which will hold the lock to
    prevent the config entry from being unloaded while its platforms are being
    setup
    
    * run with error on to find them
    
    * cert_exp, hold lock
    
    * cert_exp, hold lock
    
    * shelly async_late_forward_entry_setups
    
    * compact
    
    * compact
    
    * found another
    
    * patch up mobileapp
    
    * patch up hue tests
    
    * patch up smartthings
    
    * fix mqtt
    
    * fix esphome
    
    * zwave_js
    
    * mqtt
    
    * rework
    
    * fixes
    
    * fix mocking
    
    * fix mocking
    
    * do not call async_forward_entry_setup directly
    
    * docstrings
    
    * docstrings
    
    * docstrings
    
    * add comments
    
    * doc strings
    
    * fixed all in core, turn off strict
    
    * coverage
    
    * coverage
    
    * missing
    
    * coverage
    Ensure config entries are not unloaded while their platforms are setting up (#118767)
    J. Nick Koston authored
    * Report non-awaited/non-locked config entry platform forwards
    
    Its currently possible for config entries to be reloaded while their platforms
    are being forwarded if platform forwards are not awaited or done after the
    config entry is setup since the lock will not be held in this case.
    
    In https://developers.home-assistant.io/blog/2022/07/08/config_entry_forwards
    we advised to await platform forwards to ensure this does not happen, however
    for sleeping devices and late discovered devices, platform forwards may happen
    later.
    
    If config platform forwards are happening during setup, they should be awaited
    
    If config entry platform forwards are not happening during setup, instead
    async_late_forward_entry_setups should be used which will hold the lock to
    prevent the config entry from being unloaded while its platforms are being
    setup
    
    * Report non-awaited/non-locked config entry platform forwards
    
    Its currently possible for config entries to be reloaded while their platforms
    are being forwarded if platform forwards are not awaited or done after the
    config entry is setup since the lock will not be held in this case.
    
    In https://developers.home-assistant.io/blog/2022/07/08/config_entry_forwards
    we advised to await platform forwards to ensure this does not happen, however
    for sleeping devices and late discovered devices, platform forwards may happen
    later.
    
    If config platform forwards are happening during setup, they should be awaited
    
    If config entry platform forwards are not happening during setup, instead
    async_late_forward_entry_setups should be used which will hold the lock to
    prevent the config entry from being unloaded while its platforms are being
    setup
    
    * run with error on to find them
    
    * cert_exp, hold lock
    
    * cert_exp, hold lock
    
    * shelly async_late_forward_entry_setups
    
    * compact
    
    * compact
    
    * found another
    
    * patch up mobileapp
    
    * patch up hue tests
    
    * patch up smartthings
    
    * fix mqtt
    
    * fix esphome
    
    * zwave_js
    
    * mqtt
    
    * rework
    
    * fixes
    
    * fix mocking
    
    * fix mocking
    
    * do not call async_forward_entry_setup directly
    
    * docstrings
    
    * docstrings
    
    * docstrings
    
    * add comments
    
    * doc strings
    
    * fixed all in core, turn off strict
    
    * coverage
    
    * coverage
    
    * missing
    
    * coverage
Code owners
Assign users and groups as approvers for specific file changes. Learn more.