From 1f48243badd39c981898b1bb86b48a8a773aea10 Mon Sep 17 00:00:00 2001
From: Fredrik Thulin <fredrik@thulin.net>
Date: Mon, 21 Jan 2013 14:12:44 +0100
Subject: [PATCH] Add XXX comment about UTF-8 (space strings) in byte buffers.

---
 gck-rpc-message.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gck-rpc-message.c b/gck-rpc-message.c
index a99ecdf..9bb10f1 100644
--- a/gck-rpc-message.c
+++ b/gck-rpc-message.c
@@ -475,5 +475,8 @@ gck_rpc_message_write_space_string(GckRpcMessage * msg, CK_UTF8CHAR * buffer,
 
 	assert(!msg->signature || gck_rpc_message_verify_part(msg, "s"));
 
+	/* XXX it's not really right to treat UTF-8 input as a byte buffer,
+	 * although CK_UTF8CHAR is currently typedef'd to unsigned char in pkcs11.h.
+	 */
 	return egg_buffer_add_byte_array(&msg->buffer, buffer, length);
 }
-- 
GitLab