From c8656f1738d701fcb3184d11fe2de2c72db5d4dc Mon Sep 17 00:00:00 2001
From: deep1401 <gandhi0869@gmail.com>
Date: Mon, 3 Mar 2025 07:37:34 -0800
Subject: [PATCH] Remove chart option to prevent redundancy
---
src/renderer/components/Experiment/Eval/Chart.tsx | 1 -
src/renderer/components/Experiment/Eval/EvalJobsTable.tsx | 4 ----
src/renderer/components/Experiment/Eval/ViewPlotModal.tsx | 6 +-----
3 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/renderer/components/Experiment/Eval/Chart.tsx b/src/renderer/components/Experiment/Eval/Chart.tsx
index 4800dbc2..baea2121 100644
--- a/src/renderer/components/Experiment/Eval/Chart.tsx
+++ b/src/renderer/components/Experiment/Eval/Chart.tsx
@@ -16,7 +16,6 @@ const Chart = ({ metrics, compareChart }) => {
return <div>No metrics available</div>;
}
- console.log("METRICS", metrics);
let barData, lineData, radarData;
diff --git a/src/renderer/components/Experiment/Eval/EvalJobsTable.tsx b/src/renderer/components/Experiment/Eval/EvalJobsTable.tsx
index 21156cb0..9734bf3d 100644
--- a/src/renderer/components/Experiment/Eval/EvalJobsTable.tsx
+++ b/src/renderer/components/Experiment/Eval/EvalJobsTable.tsx
@@ -185,7 +185,6 @@ const EvalJobsTable = () => {
const [openPlotModal, setOpenPlotModal] = useState(false);
const [currentJobId, setCurrentJobId] = useState('');
const [currentData, setCurrentData] = useState('');
- const [chart, setChart] = useState(true);
const [compareChart, setCompareChart] = useState(false);
const [currentTensorboardForModal, setCurrentTensorboardForModal] = useState(-1);
const [fileNameForDetailedReport, setFileNameForDetailedReport] = useState('');
@@ -222,7 +221,6 @@ const EvalJobsTable = () => {
setCurrentData(JSON.stringify(transformedData));
setOpenPlotModal(true);
- setChart(true);
setCompareChart(true);
setCurrentJobId('-1');
} else if (comparisonType === 'detailed') {
@@ -247,7 +245,6 @@ const EvalJobsTable = () => {
const handleOpenPlotModal = (jobId, score) => {
setCurrentData(score);
setOpenPlotModal(true);
- setChart(true);
setCompareChart(false);
setCurrentJobId(jobId);
};
@@ -270,7 +267,6 @@ const EvalJobsTable = () => {
onClose={() => setOpenPlotModal(false)}
data={currentData}
jobId={currentJobId}
- chart={chart}
compareChart={compareChart}
/>
<ViewOutputModalStreaming
diff --git a/src/renderer/components/Experiment/Eval/ViewPlotModal.tsx b/src/renderer/components/Experiment/Eval/ViewPlotModal.tsx
index 1d98e743..91583c70 100644
--- a/src/renderer/components/Experiment/Eval/ViewPlotModal.tsx
+++ b/src/renderer/components/Experiment/Eval/ViewPlotModal.tsx
@@ -9,7 +9,7 @@ function parseJSON(data) {
}
}
-export default function ViewPlotModal({ open, onClose, data, jobId, chart = true, compareChart= false}) {
+export default function ViewPlotModal({ open, onClose, data, jobId, compareChart= false}) {
if (!jobId) {
return <></>;
}
@@ -44,11 +44,7 @@ export default function ViewPlotModal({ open, onClose, data, jobId, chart = true
p: 2,
}}
>
- {chart ? (
<Chart metrics={parseJSON(data)} compareChart={compareChart} />
- ) : (
- <div>{JSON.stringify(parseJSON(data))}</div>
- )}
</Box>
</Box>
</ModalDialog>
--
GitLab