From 9609a1c32bc721539d042d9d3859134d0eda897a Mon Sep 17 00:00:00 2001
From: ali asaria <aliasaria@users.noreply.github.com>
Date: Wed, 26 Feb 2025 21:40:51 -0500
Subject: [PATCH] improve new node modal
---
.../Experiment/Workflows/NewNodeModal.tsx | 75 ++++++++++++-------
1 file changed, 46 insertions(+), 29 deletions(-)
diff --git a/src/renderer/components/Experiment/Workflows/NewNodeModal.tsx b/src/renderer/components/Experiment/Workflows/NewNodeModal.tsx
index 41402c52..33946144 100644
--- a/src/renderer/components/Experiment/Workflows/NewNodeModal.tsx
+++ b/src/renderer/components/Experiment/Workflows/NewNodeModal.tsx
@@ -101,36 +101,53 @@ export default function NewNodeModal({
}}
>
<Stack spacing={2}>
- <Select
- labelId="mode-label"
- id="mode-select"
- value={mode}
- onChange={handleModeChange}
- >
- <Option value="OTHER">OTHER</Option>
- <Option value="TRAIN">TRAIN</Option>
- <Option value="EVAL">EVAL</Option>
- </Select>
- <FormLabel>Name</FormLabel>
- <Textarea minRows={4} autoFocus required name="name" />
- {mode == 'TRAIN' ? (
- <Select name="trainingTemplate">
- {trainingTemplatesData.map((template) => (
- <Option value={template[1]}>{template[1]}</Option>
- ))}
+ <FormControl>
+ <FormLabel>Name</FormLabel>
+ <Input autoFocus required name="name" />
+ </FormControl>
+ <FormControl>
+ <FormLabel>Type</FormLabel>
+ <Select
+ labelId="mode-label"
+ id="mode-select"
+ value={mode}
+ onChange={handleModeChange}
+ >
+ <Option value="OTHER">OTHER</Option>
+ <Option value="TRAIN">TRAIN</Option>
+ <Option value="EVAL">EVAL</Option>
</Select>
- ) : mode == 'EVAL' ? (
- <Select name="evalTemplate">
- {evaluationData.map((template) => (
- <Option value={template.name}>{template.name}</Option>
- ))}
- </Select>
- ) : (
- <FormControl>
- <FormLabel>Nodes</FormLabel>
- <Textarea minRows={4} autoFocus required name="node" />
- </FormControl>
- )}
+ </FormControl>
+
+ <FormControl>
+ {mode == 'TRAIN' && (
+ <>
+ <FormLabel>Training Template</FormLabel>
+ <Select name="trainingTemplate">
+ {trainingTemplatesData.map((template) => (
+ <Option value={template[1]}>{template[1]}</Option>
+ ))}
+ </Select>
+ </>
+ )}
+ {mode == 'EVAL' && (
+ <>
+ <FormLabel>Eval Template</FormLabel>
+ <Select name="evalTemplate">
+ {evaluationData.map((template) => (
+ <Option value={template.name}>{template.name}</Option>
+ ))}
+ </Select>
+ </>
+ )}
+ {mode == 'OTHER' && (
+ <>
+ <FormLabel>Nodes</FormLabel>
+ <Textarea minRows={4} autoFocus required name="node" />
+ </>
+ )}
+ </FormControl>
+
<Button type="submit">Submit</Button>
</Stack>
</form>
--
GitLab