From 6911ad18bb7c869d33faadfbccd72e37e45ef753 Mon Sep 17 00:00:00 2001
From: ali asaria <aliasaria@users.noreply.github.com>
Date: Tue, 25 Feb 2025 14:00:04 -0500
Subject: [PATCH] remove default value in generate modal
---
.../Experiment/Generate/GenerateModal.tsx | 24 +++++++------------
.../Experiment/Rag/PickADocumentMenu.tsx | 8 -------
2 files changed, 9 insertions(+), 23 deletions(-)
diff --git a/src/renderer/components/Experiment/Generate/GenerateModal.tsx b/src/renderer/components/Experiment/Generate/GenerateModal.tsx
index b38f361e..292ed8c6 100644
--- a/src/renderer/components/Experiment/Generate/GenerateModal.tsx
+++ b/src/renderer/components/Experiment/Generate/GenerateModal.tsx
@@ -103,7 +103,6 @@ export default function GenerateModal({
return chatAPI.Endpoints.Dataset.Info(selectedDataset);
}, fetcher);
-
useEffect(() => {
if (open) {
if (!currentGenerationName || currentGenerationName === '') {
@@ -152,10 +151,10 @@ export default function GenerateModal({
) {
setHasContextKey(false);
setHasDocumentsKey(true);
- generationConfig.script_parameters.docs = generationConfig.script_parameters.docs.split(',');
+ generationConfig.script_parameters.docs =
+ generationConfig.script_parameters.docs.split(',');
setConfig(generationConfig.script_parameters);
setSelectedDocs(generationConfig.script_parameters.docs);
-
} else if (
contextKeyExists &&
generationConfig.script_parameters.context.length > 0
@@ -172,12 +171,14 @@ export default function GenerateModal({
hasDatasetKey &&
generationConfig.script_parameters.dataset_name.length > 0
) {
- setSelectedDataset(generationConfig.script_parameters.dataset_name);
+ setSelectedDataset(
+ generationConfig.script_parameters.dataset_name
+ );
}
if (
generationConfig.script_parameters._dataset_display_message &&
- generationConfig.script_parameters._dataset_display_message.length >
- 0
+ generationConfig.script_parameters._dataset_display_message
+ .length > 0
) {
setDatasetDisplayMessage(
generationConfig.script_parameters._dataset_display_message
@@ -225,16 +226,13 @@ export default function GenerateModal({
(key) => key.toLowerCase().includes('tflabcustomui_docs')
);
- const contextKeyExists = Object.keys(
- parsedData.parameters
- ).some((key) =>
- key.toLowerCase().includes('tflabcustomui_context')
+ const contextKeyExists = Object.keys(parsedData.parameters).some(
+ (key) => key.toLowerCase().includes('tflabcustomui_context')
);
setHasContextKey(contextKeyExists);
setHasDocumentsKey(docsKeyExists);
}
setConfig(tempconfig);
-
} catch (e) {
console.error('Error parsing data', e);
parsedData = '';
@@ -306,8 +304,6 @@ export default function GenerateModal({
showFoldersOnly={false}
value={selectedDocs}
onChange={setSelectedDocs}
- defaultValue={config.docs ? config.docs : []}
- // defaultValue={config.docs? config.docs : []}
name="docs"
/>
<FormHelperText>Select documents to upload</FormHelperText>
@@ -316,7 +312,6 @@ export default function GenerateModal({
);
}
-
function ContextTab({ contextInput, setContextInput }) {
return (
<Stack spacing={2}>
@@ -388,7 +383,6 @@ export default function GenerateModal({
}
experimentInfoMutate();
onClose();
-
} catch (error) {
console.error('Failed to edit generation:', error);
}
diff --git a/src/renderer/components/Experiment/Rag/PickADocumentMenu.tsx b/src/renderer/components/Experiment/Rag/PickADocumentMenu.tsx
index 1bd7e0f3..120bc50c 100644
--- a/src/renderer/components/Experiment/Rag/PickADocumentMenu.tsx
+++ b/src/renderer/components/Experiment/Rag/PickADocumentMenu.tsx
@@ -18,14 +18,6 @@ export default function PickADocumentMenu({
mutate,
} = useSWR(chatAPI.Endpoints.Documents.List(experimentInfo?.id, ''), fetcher);
-
- useEffect(() => {
- if (defaultValue.length > 0) {
- onChange(defaultValue);
- }
- }, [defaultValue]);
-
-
function handleChange(event, newValue) {
console.log(newValue);
onChange(newValue);
--
GitLab