From 500a8c13c4160080a3c0ee642f58c5e25a44119d Mon Sep 17 00:00:00 2001
From: deep1401 <gandhi0869@gmail.com>
Date: Fri, 28 Feb 2025 07:44:37 -0800
Subject: [PATCH] Remove function from api file and make it a url and move
logic to the component
---
.../Experiment/Eval/EvalJobsTable.tsx | 18 ++++++++++------
src/renderer/lib/transformerlab-api-sdk.ts | 21 +++++--------------
2 files changed, 17 insertions(+), 22 deletions(-)
diff --git a/src/renderer/components/Experiment/Eval/EvalJobsTable.tsx b/src/renderer/components/Experiment/Eval/EvalJobsTable.tsx
index 846b637c..481c36d4 100644
--- a/src/renderer/components/Experiment/Eval/EvalJobsTable.tsx
+++ b/src/renderer/components/Experiment/Eval/EvalJobsTable.tsx
@@ -121,10 +121,16 @@ const EvalJobsTable = () => {
fallbackData: [],
});
- // New function to call CombinedReports via SDK and send data to ViewPlotModal
const handleCombinedReports = async () => {
try {
- const data = await chatAPI.COMPARE_EVALS(selected);
+ const jobIdsParam = selected.join(',');
+ const compareEvalsUrl = chatAPI.Endpoints.Charts.CompareEvals(jobIdsParam);
+ const response = await fetch(compareEvalsUrl, { method: 'GET' });
+ if (!response.ok) {
+ throw new Error('Network response was not ok');
+ }
+ const data = await response.json();
+ console.log('data', data);
setCurrentData(JSON.stringify(data));
setOpenPlotModal(true);
setChart(false);
@@ -187,10 +193,10 @@ const EvalJobsTable = () => {
level="body-sm"
startDecorator={<ChartColumnIncreasingIcon size="20px" />}
// Uncomment this line to enable the combined reports feature
- // onClick={handleCombinedReports}
- onClick={() => {
- alert('this feature coming soon');
- }}
+ onClick={handleCombinedReports}
+ // onClick={() => {
+ // alert('this feature coming soon');
+ // }}
sx={{ cursor: 'pointer' }}
>
<>Compare Selected Evals</>
diff --git a/src/renderer/lib/transformerlab-api-sdk.ts b/src/renderer/lib/transformerlab-api-sdk.ts
index 10566166..7034f8b9 100644
--- a/src/renderer/lib/transformerlab-api-sdk.ts
+++ b/src/renderer/lib/transformerlab-api-sdk.ts
@@ -1196,6 +1196,11 @@ Endpoints.ServerInfo = {
StreamLog: () => API_URL() + 'server/stream_log',
};
+Endpoints.Charts = {
+ CompareEvals: (jobIds: string) =>
+ API_URL() + 'evals/compare_evals?job_list=' + jobIds,
+}
+
export function GET_TRAINING_TEMPLATE_URL() {
return API_URL() + 'train/templates';
}
@@ -1551,22 +1556,6 @@ export async function EXPERIMENT_EDIT_EVALUATION(
return result;
}
-export async function COMPARE_EVALS(jobIds: string[]) {
- const jobIdsParam = jobIds.join(',');
- const url = API_URL() + 'evals/compare_evals?job_list=' + jobIdsParam;
- console.log('url', url);
- console.log('jobIds', jobIds);
- const response = await fetch(url, {
- method: 'GET'
- });
- if (!response.ok) {
- throw new Error('Network response was not ok');
- }
- const data = await response.json();
- console.log('data', data);
- return data;
-}
-
export async function EXPERIMENT_ADD_GENERATION(
id: string,
name: string,
--
GitLab