From ab367af700b50d115d3d58e3bfe228955bfed029 Mon Sep 17 00:00:00 2001
From: Michael David <michael.david@yardi.com>
Date: Fri, 23 Feb 2024 11:37:22 -0800
Subject: [PATCH] Fix milvus delete with ref_doc_ids when they don't exist
(#11315)
---
.../llama_index/vector_stores/milvus/base.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/llama-index-integrations/vector_stores/llama-index-vector-stores-milvus/llama_index/vector_stores/milvus/base.py b/llama-index-integrations/vector_stores/llama-index-vector-stores-milvus/llama_index/vector_stores/milvus/base.py
index 65d8fafb00..570ed49fc0 100644
--- a/llama-index-integrations/vector_stores/llama-index-vector-stores-milvus/llama_index/vector_stores/milvus/base.py
+++ b/llama-index-integrations/vector_stores/llama-index-vector-stores-milvus/llama_index/vector_stores/milvus/base.py
@@ -221,9 +221,10 @@ class MilvusVectorStore(VectorStore):
collection_name=self.collection_name,
filter=f"{self.doc_id_field} in [{','.join(doc_ids)}]",
)
- ids = [entry["id"] for entry in entries]
- self.milvusclient.delete(collection_name=self.collection_name, pks=ids)
- logger.debug(f"Successfully deleted embedding with doc_id: {doc_ids}")
+ if len(entries) > 0:
+ ids = [entry["id"] for entry in entries]
+ self.milvusclient.delete(collection_name=self.collection_name, pks=ids)
+ logger.debug(f"Successfully deleted embedding with doc_id: {doc_ids}")
def query(self, query: VectorStoreQuery, **kwargs: Any) -> VectorStoreQueryResult:
"""Query index for top k most similar nodes.
--
GitLab