From 7b9c95a72184602c068c18150c866d23d23f9a26 Mon Sep 17 00:00:00 2001
From: Marcus Schiesser <mail@marcusschiesser.de>
Date: Wed, 6 Dec 2023 14:51:29 +0700
Subject: [PATCH] fix: don't use frontend for backends of type non-streaming
---
e2e/basic.spec.ts | 10 +++++++---
e2e/utils.ts | 5 -----
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/e2e/basic.spec.ts b/e2e/basic.spec.ts
index da6a739c..dbc44114 100644
--- a/e2e/basic.spec.ts
+++ b/e2e/basic.spec.ts
@@ -27,7 +27,9 @@ for (const templateType of templateTypes) {
}
const appType: AppType =
templateFramework === "express" || templateFramework === "fastapi"
- ? "--frontend"
+ ? templateType === "simple"
+ ? "--no-frontend" // simple templates don't have frontends
+ : "--frontend"
: "";
test(`try create-llama ${templateType} ${templateFramework} ${templateEngine} ${templateUI} ${appType}`, async ({
page,
@@ -46,8 +48,10 @@ for (const templateType of templateTypes) {
const cps = await runApp(cwd, name, appType, port);
// test frontend
- await page.goto(`http://localhost:${port}`);
- await expect(page.getByText("Built by LlamaIndex")).toBeVisible();
+ if (appType !== "--no-frontend") {
+ await page.goto(`http://localhost:${port}`);
+ await expect(page.getByText("Built by LlamaIndex")).toBeVisible();
+ }
// TODO: test backend using curl (would need OpenAI key)
// clean processes
cps.forEach((cp) => cp.kill());
diff --git a/e2e/utils.ts b/e2e/utils.ts
index 6e134495..3085263d 100644
--- a/e2e/utils.ts
+++ b/e2e/utils.ts
@@ -17,11 +17,6 @@ export async function runApp(
try {
switch (appType) {
- case "--no-frontend":
- cps.push(
- await createProcess("npm run dev", `${cwd}/${name}/backend`, port),
- );
- break;
case "--frontend":
cps.push(
await createProcess(
--
GitLab