From 68fc6e8b5068e13860fbc088e4ad420feb51da38 Mon Sep 17 00:00:00 2001
From: Marcus Schiesser <mail@marcusschiesser.de>
Date: Fri, 23 Feb 2024 11:42:41 +0700
Subject: [PATCH] fix: don't need similarityTopK parameter for LlamaCloud
---
packages/core/src/cloud/LlamaCloudIndex.ts | 2 +-
packages/core/src/cloud/LlamaCloudRetriever.ts | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/packages/core/src/cloud/LlamaCloudIndex.ts b/packages/core/src/cloud/LlamaCloudIndex.ts
index 058be7ccd..0daa76c8d 100644
--- a/packages/core/src/cloud/LlamaCloudIndex.ts
+++ b/packages/core/src/cloud/LlamaCloudIndex.ts
@@ -13,7 +13,7 @@ export class LlamaCloudIndex {
this.params = params;
}
- asRetriever(params: RetrieveParams): BaseRetriever {
+ asRetriever(params: RetrieveParams = {}): BaseRetriever {
return new LlamaCloudRetriever({ ...this.params, ...params });
}
diff --git a/packages/core/src/cloud/LlamaCloudRetriever.ts b/packages/core/src/cloud/LlamaCloudRetriever.ts
index 43616b80c..977383134 100644
--- a/packages/core/src/cloud/LlamaCloudRetriever.ts
+++ b/packages/core/src/cloud/LlamaCloudRetriever.ts
@@ -38,8 +38,9 @@ export class LlamaCloudRetriever implements BaseRetriever {
constructor(params: CloudConstructorParams & RetrieveParams) {
this.clientParams = { apiKey: params.apiKey, baseUrl: params.baseUrl };
- params.denseSimilarityTopK =
- params.similarityTopK ?? params.denseSimilarityTopK;
+ if (params.similarityTopK) {
+ params.denseSimilarityTopK = params.similarityTopK;
+ }
this.retrieveParams = params;
this.pipelineName = params.name;
if (params.projectName) {
--
GitLab