From 2212793420b6b287f6edb8df7eb4d79e9d9f410f Mon Sep 17 00:00:00 2001
From: Yi Ding <yi.s.ding@gmail.com>
Date: Tue, 4 Jul 2023 09:47:44 -0700
Subject: [PATCH] more housekeeping

---
 packages/core/src/Embedding.ts           | 18 +++---------------
 packages/core/src/NodeParser.ts          |  2 +-
 packages/core/src/ResponseSynthesizer.ts |  1 +
 3 files changed, 5 insertions(+), 16 deletions(-)

diff --git a/packages/core/src/Embedding.ts b/packages/core/src/Embedding.ts
index 7d2208669..bb824bc0e 100644
--- a/packages/core/src/Embedding.ts
+++ b/packages/core/src/Embedding.ts
@@ -174,24 +174,12 @@ export function getTopKMMREmbeddings(
 }
 
 export abstract class BaseEmbedding {
-  static similarity(
+  similarity(
     embedding1: number[],
     embedding2: number[],
-    mode: SimilarityType = SimilarityType.DOT_PRODUCT
+    mode: SimilarityType = SimilarityType.DEFAULT
   ): number {
-    if (embedding1.length !== embedding2.length) {
-      throw new Error("Embedding length mismatch");
-    }
-
-    if (mode === SimilarityType.DOT_PRODUCT) {
-      let result = 0;
-      for (let i = 0; i < embedding1.length; i++) {
-        result += embedding1[i] * embedding2[i];
-      }
-      return result;
-    } else {
-      throw new Error("Not implemented yet");
-    }
+    return similarity(embedding1, embedding2, mode);
   }
 
   abstract aGetTextEmbedding(text: string): Promise<number[]>;
diff --git a/packages/core/src/NodeParser.ts b/packages/core/src/NodeParser.ts
index 52db5dfba..7f191e222 100644
--- a/packages/core/src/NodeParser.ts
+++ b/packages/core/src/NodeParser.ts
@@ -19,7 +19,7 @@ export function getNodesFromDocument(
 
   const textSplits = getTextSplitsFromDocument(document, textSplitter);
 
-  textSplits.forEach((textSplit, index) => {
+  textSplits.forEach((textSplit) => {
     const node = new TextNode({ text: textSplit });
     node.relationships[NodeRelationship.SOURCE] = document.asRelatedNodeInfo();
     nodes.push(node);
diff --git a/packages/core/src/ResponseSynthesizer.ts b/packages/core/src/ResponseSynthesizer.ts
index 8e2bc4b63..b2f347edd 100644
--- a/packages/core/src/ResponseSynthesizer.ts
+++ b/packages/core/src/ResponseSynthesizer.ts
@@ -182,6 +182,7 @@ export function getResponseBuilder(): BaseResponseBuilder {
   return new SimpleResponseBuilder();
 }
 
+// TODO replace with Logan's new response_sythesizers/factory.py
 export class ResponseSynthesizer {
   responseBuilder: BaseResponseBuilder;
 
-- 
GitLab