diff --git a/packages/core/src/Embedding.ts b/packages/core/src/Embedding.ts index 7d2208669b3627bf66b16d67ca221b8c61b03455..bb824bc0efe5a929b922bf035601ae97a22e03db 100644 --- a/packages/core/src/Embedding.ts +++ b/packages/core/src/Embedding.ts @@ -174,24 +174,12 @@ export function getTopKMMREmbeddings( } export abstract class BaseEmbedding { - static similarity( + similarity( embedding1: number[], embedding2: number[], - mode: SimilarityType = SimilarityType.DOT_PRODUCT + mode: SimilarityType = SimilarityType.DEFAULT ): number { - if (embedding1.length !== embedding2.length) { - throw new Error("Embedding length mismatch"); - } - - if (mode === SimilarityType.DOT_PRODUCT) { - let result = 0; - for (let i = 0; i < embedding1.length; i++) { - result += embedding1[i] * embedding2[i]; - } - return result; - } else { - throw new Error("Not implemented yet"); - } + return similarity(embedding1, embedding2, mode); } abstract aGetTextEmbedding(text: string): Promise<number[]>; diff --git a/packages/core/src/NodeParser.ts b/packages/core/src/NodeParser.ts index 52db5dfbae7bfc1471d98099e0d7d646cb3c2756..7f191e222dc767c61c16f84b6353af4e4667f9ac 100644 --- a/packages/core/src/NodeParser.ts +++ b/packages/core/src/NodeParser.ts @@ -19,7 +19,7 @@ export function getNodesFromDocument( const textSplits = getTextSplitsFromDocument(document, textSplitter); - textSplits.forEach((textSplit, index) => { + textSplits.forEach((textSplit) => { const node = new TextNode({ text: textSplit }); node.relationships[NodeRelationship.SOURCE] = document.asRelatedNodeInfo(); nodes.push(node); diff --git a/packages/core/src/ResponseSynthesizer.ts b/packages/core/src/ResponseSynthesizer.ts index 8e2bc4b63c75445a8942903656d9b4b0ceb781a2..b2f347eddabe7fed57355d249e33986dd61ec7f8 100644 --- a/packages/core/src/ResponseSynthesizer.ts +++ b/packages/core/src/ResponseSynthesizer.ts @@ -182,6 +182,7 @@ export function getResponseBuilder(): BaseResponseBuilder { return new SimpleResponseBuilder(); } +// TODO replace with Logan's new response_sythesizers/factory.py export class ResponseSynthesizer { responseBuilder: BaseResponseBuilder;