From 81939fe26d963da050c27431c20caccd7be0432c Mon Sep 17 00:00:00 2001
From: timothycarambat <rambat1010@gmail.com>
Date: Wed, 29 Jan 2025 12:03:12 -0800
Subject: [PATCH] Patch gear showing on llms with no settings
---
.../AgentLLMSelection/AgentLLMItem/index.jsx | 27 ++++++++++---------
.../AgentConfig/AgentLLMSelection/index.jsx | 5 ++--
.../WorkspaceLLMItem/index.jsx | 3 ++-
3 files changed, 20 insertions(+), 15 deletions(-)
diff --git a/frontend/src/pages/WorkspaceSettings/AgentConfig/AgentLLMSelection/AgentLLMItem/index.jsx b/frontend/src/pages/WorkspaceSettings/AgentConfig/AgentLLMSelection/AgentLLMItem/index.jsx
index 02be032dc..3dc8953c4 100644
--- a/frontend/src/pages/WorkspaceSettings/AgentConfig/AgentLLMSelection/AgentLLMItem/index.jsx
+++ b/frontend/src/pages/WorkspaceSettings/AgentConfig/AgentLLMSelection/AgentLLMItem/index.jsx
@@ -9,6 +9,7 @@ import System from "@/models/system";
import showToast from "@/utils/toast";
import { useEffect, useState } from "react";
+const NO_SETTINGS_NEEDED = ["default", "none"];
export default function AgentLLMItem({
llm,
availableLLMs,
@@ -73,18 +74,20 @@ export default function AgentLLMItem({
<div className="mt-1 text-xs text-white/60">{description}</div>
</div>
</div>
- {checked && value !== "none" && (
- <button
- onClick={(e) => {
- e.preventDefault();
- openModal();
- }}
- className="p-2 text-white/60 hover:text-white hover:bg-theme-bg-hover rounded-md transition-all duration-300"
- title="Edit Settings"
- >
- <Gear size={20} weight="bold" />
- </button>
- )}
+ {checked &&
+ value !== "none" &&
+ !NO_SETTINGS_NEEDED.includes(value) && (
+ <button
+ onClick={(e) => {
+ e.preventDefault();
+ openModal();
+ }}
+ className="border-none p-2 text-white/60 hover:text-white hover:bg-theme-bg-hover rounded-md transition-all duration-300"
+ title="Edit Settings"
+ >
+ <Gear size={20} weight="bold" />
+ </button>
+ )}
</div>
</div>
<SetupProvider
diff --git a/frontend/src/pages/WorkspaceSettings/AgentConfig/AgentLLMSelection/index.jsx b/frontend/src/pages/WorkspaceSettings/AgentConfig/AgentLLMSelection/index.jsx
index effc7b744..ca936a831 100644
--- a/frontend/src/pages/WorkspaceSettings/AgentConfig/AgentLLMSelection/index.jsx
+++ b/frontend/src/pages/WorkspaceSettings/AgentConfig/AgentLLMSelection/index.jsx
@@ -48,11 +48,12 @@ const WARN_PERFORMANCE = [
];
const LLM_DEFAULT = {
- name: "Please make a selection",
+ name: "System Default",
value: "none",
logo: AnythingLLMIcon,
options: () => <React.Fragment />,
- description: "Agents will not work until a valid selection is made.",
+ description:
+ "Agents will use the workspace or system LLM unless otherwise specified.",
requiredConfig: [],
};
diff --git a/frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/WorkspaceLLMItem/index.jsx b/frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/WorkspaceLLMItem/index.jsx
index ee123556c..9c5e06fce 100644
--- a/frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/WorkspaceLLMItem/index.jsx
+++ b/frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/WorkspaceLLMItem/index.jsx
@@ -9,6 +9,7 @@ import System from "@/models/system";
import showToast from "@/utils/toast";
import { useEffect, useState } from "react";
+const NO_SETTINGS_NEEDED = ["default"];
export default function WorkspaceLLM({
llm,
availableLLMs,
@@ -73,7 +74,7 @@ export default function WorkspaceLLM({
<div className="mt-1 text-xs text-white/60">{description}</div>
</div>
</div>
- {checked && (
+ {checked && !NO_SETTINGS_NEEDED.includes(value) && (
<button
onClick={(e) => {
e.preventDefault();
--
GitLab