From 48b7d54b529e2dd3f57bd39b129eefded95f746d Mon Sep 17 00:00:00 2001
From: Sean Hatfield <seanhatfield5@gmail.com>
Date: Fri, 7 Jun 2024 12:03:48 -0700
Subject: [PATCH] [FIX] Delete SQL agent connection bug fix (#1635)
fix update agent settings button not appearing when deleting sql connection
---
.../AgentConfig/SQLConnectorSelection/DBConnection.jsx | 3 ++-
.../AgentConfig/SQLConnectorSelection/index.jsx | 2 ++
frontend/src/pages/WorkspaceSettings/AgentConfig/index.jsx | 4 +++-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/frontend/src/pages/WorkspaceSettings/AgentConfig/SQLConnectorSelection/DBConnection.jsx b/frontend/src/pages/WorkspaceSettings/AgentConfig/SQLConnectorSelection/DBConnection.jsx
index 7a58da454..b2ff33bfc 100644
--- a/frontend/src/pages/WorkspaceSettings/AgentConfig/SQLConnectorSelection/DBConnection.jsx
+++ b/frontend/src/pages/WorkspaceSettings/AgentConfig/SQLConnectorSelection/DBConnection.jsx
@@ -9,7 +9,7 @@ export const DB_LOGOS = {
"sql-server": MSSQLLogo,
};
-export default function DBConnection({ connection, onRemove }) {
+export default function DBConnection({ connection, onRemove, setHasChanges }) {
const { database_id, engine } = connection;
function removeConfirmation() {
if (
@@ -20,6 +20,7 @@ export default function DBConnection({ connection, onRemove }) {
return false;
}
onRemove(database_id);
+ setHasChanges(true);
}
return (
diff --git a/frontend/src/pages/WorkspaceSettings/AgentConfig/SQLConnectorSelection/index.jsx b/frontend/src/pages/WorkspaceSettings/AgentConfig/SQLConnectorSelection/index.jsx
index 9feb4b8bb..848d44ed9 100644
--- a/frontend/src/pages/WorkspaceSettings/AgentConfig/SQLConnectorSelection/index.jsx
+++ b/frontend/src/pages/WorkspaceSettings/AgentConfig/SQLConnectorSelection/index.jsx
@@ -9,6 +9,7 @@ export default function AgentSQLConnectorSelection({
settings,
toggleSkill,
enabled = false,
+ setHasChanges,
}) {
const { isOpen, openModal, closeModal } = useModal();
const [connections, setConnections] = useState(
@@ -72,6 +73,7 @@ export default function AgentSQLConnectorSelection({
})
);
}}
+ setHasChanges={setHasChanges}
/>
))}
<button
diff --git a/frontend/src/pages/WorkspaceSettings/AgentConfig/index.jsx b/frontend/src/pages/WorkspaceSettings/AgentConfig/index.jsx
index 02065251a..9fb6f5d74 100644
--- a/frontend/src/pages/WorkspaceSettings/AgentConfig/index.jsx
+++ b/frontend/src/pages/WorkspaceSettings/AgentConfig/index.jsx
@@ -100,6 +100,7 @@ export default function WorkspaceAgentConfiguration({ workspace }) {
skills={agentSkills}
toggleAgentSkill={toggleAgentSkill}
settings={settings}
+ setHasChanges={setHasChanges}
/>
{hasChanges && (
<button
@@ -143,7 +144,7 @@ function LoadingSkeleton() {
);
}
-function AvailableAgentSkills({ skills, settings, toggleAgentSkill }) {
+function AvailableAgentSkills({ skills, settings, toggleAgentSkill, setHasChanges }) {
return (
<div>
<div className="flex flex-col mb-8">
@@ -211,6 +212,7 @@ function AvailableAgentSkills({ skills, settings, toggleAgentSkill }) {
settings={settings}
toggleSkill={toggleAgentSkill}
enabled={skills.includes("sql-agent")}
+ setHasChanges={setHasChanges}
/>
</div>
</div>
--
GitLab