From 273d824df4e79ab096fd2e85ecc7b6c1e3d95d90 Mon Sep 17 00:00:00 2001
From: timothycarambat <rambat1010@gmail.com>
Date: Wed, 6 Mar 2024 17:14:17 -0800
Subject: [PATCH] patch: do not block response if user password check failed

---
 server/endpoints/admin.js | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/server/endpoints/admin.js b/server/endpoints/admin.js
index a54e0abd4..792cf2dd9 100644
--- a/server/endpoints/admin.js
+++ b/server/endpoints/admin.js
@@ -59,14 +59,17 @@ function adminEndpoints(app) {
         }
 
         const { user: newUser, error } = await User.create(newUserParams);
-        await EventLogs.logEvent(
-          "user_created",
-          {
-            userName: newUser.username,
-            createdBy: currUser.username,
-          },
-          currUser.id
-        );
+        if (!!newUser) {
+          await EventLogs.logEvent(
+            "user_created",
+            {
+              userName: newUser.username,
+              createdBy: currUser.username,
+            },
+            currUser.id
+          );
+        }
+
         response.status(200).json({ user: newUser, error });
       } catch (e) {
         console.error(e);
-- 
GitLab