From e1e731eb4828eaf3888afc11a930085b13d20833 Mon Sep 17 00:00:00 2001
From: epenet <6771947+epenet@users.noreply.github.com>
Date: Tue, 5 Nov 2024 08:56:58 +0100
Subject: [PATCH] Drop use of initialize_options in onkyo (#129869)
* Drop use of initialize_options in onkyo
* Apply suggestions from code review
Co-authored-by: Artur Pragacz <49985303+arturpragacz@users.noreply.github.com>
---------
Co-authored-by: Artur Pragacz <49985303+arturpragacz@users.noreply.github.com>
---
homeassistant/components/onkyo/config_flow.py | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/homeassistant/components/onkyo/config_flow.py b/homeassistant/components/onkyo/config_flow.py
index 9ab01b3d904..623fa9b2a90 100644
--- a/homeassistant/components/onkyo/config_flow.py
+++ b/homeassistant/components/onkyo/config_flow.py
@@ -327,10 +327,8 @@ class OnkyoOptionsFlowHandler(OptionsFlow):
def __init__(self, config_entry: ConfigEntry) -> None:
"""Initialize options flow."""
- self.initialize_options(config_entry)
- sources_store: dict[str, str] = self.options[OPTION_INPUT_SOURCES]
- sources = {InputSource(k): v for k, v in sources_store.items()}
- self.options[OPTION_INPUT_SOURCES] = sources
+ sources_store: dict[str, str] = config_entry.options[OPTION_INPUT_SOURCES]
+ self._input_sources = {InputSource(k): v for k, v in sources_store.items()}
async def async_step_init(
self, user_input: dict[str, Any] | None = None
@@ -360,15 +358,12 @@ class OnkyoOptionsFlowHandler(OptionsFlow):
)
)
- sources: dict[InputSource, str] = self.options[OPTION_INPUT_SOURCES]
- for source in sources:
- schema_dict[vol.Required(source.value_meaning, default=sources[source])] = (
+ for source, source_name in self._input_sources.items():
+ schema_dict[vol.Required(source.value_meaning, default=source_name)] = (
TextSelector()
)
- schema = vol.Schema(schema_dict)
-
return self.async_show_form(
step_id="init",
- data_schema=schema,
+ data_schema=vol.Schema(schema_dict),
)
--
GitLab