From d8564eba1719df318617f3a26d4c481aedf26bd3 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" <nick@koston.org> Date: Sat, 13 Jan 2024 16:08:42 -1000 Subject: [PATCH] Bump lxml to 5.1.0 (#106696) * Bump lxml to 5.0.0 cython 3.0.7+ is required ? * bump * Apply suggestions from code review * 5.1.0 --- homeassistant/components/scrape/manifest.json | 2 +- homeassistant/package_constraints.txt | 4 ---- requirements_all.txt | 2 +- requirements_test_all.txt | 2 +- script/gen_requirements_all.py | 4 ---- 5 files changed, 3 insertions(+), 11 deletions(-) diff --git a/homeassistant/components/scrape/manifest.json b/homeassistant/components/scrape/manifest.json index 708ecc14d16..ade210b304a 100644 --- a/homeassistant/components/scrape/manifest.json +++ b/homeassistant/components/scrape/manifest.json @@ -6,5 +6,5 @@ "config_flow": true, "documentation": "https://www.home-assistant.io/integrations/scrape", "iot_class": "cloud_polling", - "requirements": ["beautifulsoup4==4.12.2", "lxml==4.9.4"] + "requirements": ["beautifulsoup4==4.12.2", "lxml==5.1.0"] } diff --git a/homeassistant/package_constraints.txt b/homeassistant/package_constraints.txt index 98d5b9a1967..c62a64f8de2 100644 --- a/homeassistant/package_constraints.txt +++ b/homeassistant/package_constraints.txt @@ -182,10 +182,6 @@ get-mac==1000000000.0.0 # In order to do so, we need to constrain the version. charset-normalizer==3.2.0 -# lxml 5.0.0 currently does not build on alpine 3.18 -# https://bugs.launchpad.net/lxml/+bug/2047718 -lxml==4.9.4 - # dacite: Ensure we have a version that is able to handle type unions for # Roborock, NAM, Brother, and GIOS. dacite>=1.7.0 diff --git a/requirements_all.txt b/requirements_all.txt index 02afa578fb2..3a30320ae7a 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -1228,7 +1228,7 @@ lupupy==0.3.1 lw12==0.9.2 # homeassistant.components.scrape -lxml==4.9.4 +lxml==5.1.0 # homeassistant.components.nmap_tracker mac-vendor-lookup==0.1.12 diff --git a/requirements_test_all.txt b/requirements_test_all.txt index 74b15ac523c..c70b173ec89 100644 --- a/requirements_test_all.txt +++ b/requirements_test_all.txt @@ -964,7 +964,7 @@ loqedAPI==2.1.8 luftdaten==0.7.4 # homeassistant.components.scrape -lxml==4.9.4 +lxml==5.1.0 # homeassistant.components.nmap_tracker mac-vendor-lookup==0.1.12 diff --git a/script/gen_requirements_all.py b/script/gen_requirements_all.py index 7f652b14302..70d20f7e135 100755 --- a/script/gen_requirements_all.py +++ b/script/gen_requirements_all.py @@ -175,10 +175,6 @@ get-mac==1000000000.0.0 # In order to do so, we need to constrain the version. charset-normalizer==3.2.0 -# lxml 5.0.0 currently does not build on alpine 3.18 -# https://bugs.launchpad.net/lxml/+bug/2047718 -lxml==4.9.4 - # dacite: Ensure we have a version that is able to handle type unions for # Roborock, NAM, Brother, and GIOS. dacite>=1.7.0 -- GitLab