From a97434976e44b952f50b38d937936bb9d13f97cb Mon Sep 17 00:00:00 2001
From: Marcel van der Veldt <m.vanderveldt@outlook.com>
Date: Thu, 19 Dec 2024 19:00:18 +0100
Subject: [PATCH] Handle null value for elapsed time in Music Assistant
(#133597)
---
homeassistant/components/music_assistant/media_player.py | 8 ++------
tests/components/music_assistant/fixtures/players.json | 2 +-
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/homeassistant/components/music_assistant/media_player.py b/homeassistant/components/music_assistant/media_player.py
index 7d09bd5b888..7004f09aad5 100644
--- a/homeassistant/components/music_assistant/media_player.py
+++ b/homeassistant/components/music_assistant/media_player.py
@@ -565,17 +565,13 @@ class MusicAssistantPlayer(MusicAssistantEntity, MediaPlayerEntity):
# shuffle and repeat are not (yet) supported for external sources
self._attr_shuffle = None
self._attr_repeat = None
- if TYPE_CHECKING:
- assert player.elapsed_time is not None
- self._attr_media_position = int(player.elapsed_time)
+ self._attr_media_position = int(player.elapsed_time or 0)
self._attr_media_position_updated_at = (
utc_from_timestamp(player.elapsed_time_last_updated)
if player.elapsed_time_last_updated
else None
)
- if TYPE_CHECKING:
- assert player.elapsed_time is not None
- self._prev_time = player.elapsed_time
+ self._prev_time = player.elapsed_time or 0
return
if queue is None:
diff --git a/tests/components/music_assistant/fixtures/players.json b/tests/components/music_assistant/fixtures/players.json
index 2d8b88d0e8e..8a08a55dc45 100644
--- a/tests/components/music_assistant/fixtures/players.json
+++ b/tests/components/music_assistant/fixtures/players.json
@@ -20,7 +20,7 @@
"power",
"enqueue"
],
- "elapsed_time": 0,
+ "elapsed_time": null,
"elapsed_time_last_updated": 0,
"state": "idle",
"volume_level": 20,
--
GitLab