From 9a3fe691b1a52be49dc0da602b7e6a9812da57c7 Mon Sep 17 00:00:00 2001 From: Josh Nichols <josh@technicalpickles.com> Date: Tue, 6 Dec 2016 23:31:07 -0500 Subject: [PATCH] Updated python-nest dependency (#4785) * Updated python-nest dependency This sha fixes two issues: - min and max temperatures not being set when temperature isn't locked - fixes error when setting farenheit with a .5 * gen requirements all * Add fix for https://github.com/home-assistant/home-assistant/issues/4731 --- homeassistant/components/climate/nest.py | 14 ++++++-------- homeassistant/components/nest.py | 2 +- requirements_all.txt | 2 +- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/homeassistant/components/climate/nest.py b/homeassistant/components/climate/nest.py index dbc68162579..ab41c10e6d1 100644 --- a/homeassistant/components/climate/nest.py +++ b/homeassistant/components/climate/nest.py @@ -86,6 +86,8 @@ class NestThermostat(ClimateDevice): self._eco_temperature = None self._is_locked = None self._locked_temperature = None + self._min_temperature = None + self._max_temperature = None @property def name(self): @@ -204,18 +206,12 @@ class NestThermostat(ClimateDevice): @property def min_temp(self): """Identify min_temp in Nest API or defaults if not available.""" - if self._is_locked: - return self._locked_temperature[0] - else: - return None + return self._min_temperature @property def max_temp(self): """Identify max_temp in Nest API or defaults if not available.""" - if self._is_locked: - return self._locked_temperature[1] - else: - return None + return self._max_temperature def update(self): """Cache value from Python-nest.""" @@ -229,6 +225,8 @@ class NestThermostat(ClimateDevice): self._away = self.structure.away == 'away' self._eco_temperature = self.device.eco_temperature self._locked_temperature = self.device.locked_temperature + self._min_temperature = self.device.min_temperature + self._max_temperature = self.device.max_temperature self._is_locked = self.device.is_locked if self.device.temperature_scale == 'C': self._temperature_scale = TEMP_CELSIUS diff --git a/homeassistant/components/nest.py b/homeassistant/components/nest.py index e19011c47b8..0952129c439 100644 --- a/homeassistant/components/nest.py +++ b/homeassistant/components/nest.py @@ -19,7 +19,7 @@ _LOGGER = logging.getLogger(__name__) REQUIREMENTS = [ 'http://github.com/technicalpickles/python-nest' - '/archive/2512973b4b390d3965da43529cd20402ad374bfa.zip' # nest-cam branch + '/archive/dd628f90772d170b9602f262d5d2e7d61bdd3cf5.zip' # nest-cam branch '#python-nest==3.0.0'] DOMAIN = 'nest' diff --git a/requirements_all.txt b/requirements_all.txt index 6f1ca5eb4e1..bcc9836fdc9 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -167,7 +167,7 @@ hikvision==0.4 # http://github.com/adafruit/Adafruit_Python_DHT/archive/310c59b0293354d07d94375f1365f7b9b9110c7d.zip#Adafruit_DHT==1.3.0 # homeassistant.components.nest -http://github.com/technicalpickles/python-nest/archive/2512973b4b390d3965da43529cd20402ad374bfa.zip#python-nest==3.0.0 +http://github.com/technicalpickles/python-nest/archive/dd628f90772d170b9602f262d5d2e7d61bdd3cf5.zip#python-nest==3.0.0 # homeassistant.components.light.flux_led https://github.com/Danielhiversen/flux_led/archive/0.9.zip#flux_led==0.9 -- GitLab