From 8b436c43f76f7476073759555026c5d3e11fe354 Mon Sep 17 00:00:00 2001 From: Erik Montnemery <erik@montnemery.com> Date: Sun, 29 Aug 2021 18:57:18 +0200 Subject: [PATCH] Enable basic type checking for cert_expiry (#55335) --- homeassistant/components/cert_expiry/__init__.py | 3 ++- homeassistant/components/cert_expiry/config_flow.py | 4 +++- mypy.ini | 3 --- script/hassfest/mypy_config.py | 1 - 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/homeassistant/components/cert_expiry/__init__.py b/homeassistant/components/cert_expiry/__init__.py index c4381b65c49..babf81048df 100644 --- a/homeassistant/components/cert_expiry/__init__.py +++ b/homeassistant/components/cert_expiry/__init__.py @@ -3,6 +3,7 @@ from __future__ import annotations from datetime import datetime, timedelta import logging +from typing import Optional from homeassistant.config_entries import ConfigEntry from homeassistant.const import CONF_HOST, CONF_PORT @@ -44,7 +45,7 @@ async def async_unload_entry(hass, entry): return await hass.config_entries.async_unload_platforms(entry, PLATFORMS) -class CertExpiryDataUpdateCoordinator(DataUpdateCoordinator[datetime]): +class CertExpiryDataUpdateCoordinator(DataUpdateCoordinator[Optional[datetime]]): """Class to manage fetching Cert Expiry data from single endpoint.""" def __init__(self, hass, host, port): diff --git a/homeassistant/components/cert_expiry/config_flow.py b/homeassistant/components/cert_expiry/config_flow.py index d1b9588f5b1..13336c59771 100644 --- a/homeassistant/components/cert_expiry/config_flow.py +++ b/homeassistant/components/cert_expiry/config_flow.py @@ -1,4 +1,6 @@ """Config flow for the Cert Expiry platform.""" +from __future__ import annotations + import logging import voluptuous as vol @@ -25,7 +27,7 @@ class CertexpiryConfigFlow(config_entries.ConfigFlow, domain=DOMAIN): def __init__(self) -> None: """Initialize the config flow.""" - self._errors = {} + self._errors: dict[str, str] = {} async def _test_connection(self, user_input=None): """Test connection to the server and try to get the certificate.""" diff --git a/mypy.ini b/mypy.ini index 92247205c10..e2e570c18c2 100644 --- a/mypy.ini +++ b/mypy.ini @@ -1285,9 +1285,6 @@ ignore_errors = true [mypy-homeassistant.components.bmw_connected_drive.*] ignore_errors = true -[mypy-homeassistant.components.cert_expiry.*] -ignore_errors = true - [mypy-homeassistant.components.climacell.*] ignore_errors = true diff --git a/script/hassfest/mypy_config.py b/script/hassfest/mypy_config.py index 91bba97fa31..78707494ef5 100644 --- a/script/hassfest/mypy_config.py +++ b/script/hassfest/mypy_config.py @@ -17,7 +17,6 @@ IGNORED_MODULES: Final[list[str]] = [ "homeassistant.components.awair.*", "homeassistant.components.blueprint.*", "homeassistant.components.bmw_connected_drive.*", - "homeassistant.components.cert_expiry.*", "homeassistant.components.climacell.*", "homeassistant.components.cloud.*", "homeassistant.components.config.*", -- GitLab