From 4c86102dafad5cd78006a05981da48cc012d92e7 Mon Sep 17 00:00:00 2001
From: starkillerOG <starkiller.og@gmail.com>
Date: Tue, 5 Nov 2024 13:39:45 +0100
Subject: [PATCH] Add Reolink PTZ tilt position sensor (#129837)
---
homeassistant/components/reolink/icons.json | 5 ++++-
homeassistant/components/reolink/sensor.py | 11 ++++++++++-
homeassistant/components/reolink/strings.json | 3 +++
.../reolink/snapshots/test_diagnostics.ambr | 4 ++--
4 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/homeassistant/components/reolink/icons.json b/homeassistant/components/reolink/icons.json
index 5815e165607..7f4a15ffe21 100644
--- a/homeassistant/components/reolink/icons.json
+++ b/homeassistant/components/reolink/icons.json
@@ -261,7 +261,10 @@
},
"sensor": {
"ptz_pan_position": {
- "default": "mdi:pan"
+ "default": "mdi:pan-horizontal"
+ },
+ "ptz_tilt_position": {
+ "default": "mdi:pan-vertical"
},
"battery_temperature": {
"default": "mdi:thermometer"
diff --git a/homeassistant/components/reolink/sensor.py b/homeassistant/components/reolink/sensor.py
index c2fc815235e..80e58c3d5c2 100644
--- a/homeassistant/components/reolink/sensor.py
+++ b/homeassistant/components/reolink/sensor.py
@@ -58,7 +58,16 @@ SENSORS = (
state_class=SensorStateClass.MEASUREMENT,
entity_category=EntityCategory.DIAGNOSTIC,
value=lambda api, ch: api.ptz_pan_position(ch),
- supported=lambda api, ch: api.supported(ch, "ptz_position"),
+ supported=lambda api, ch: api.supported(ch, "ptz_pan_position"),
+ ),
+ ReolinkSensorEntityDescription(
+ key="ptz_tilt_position",
+ cmd_key="GetPtzCurPos",
+ translation_key="ptz_tilt_position",
+ state_class=SensorStateClass.MEASUREMENT,
+ entity_category=EntityCategory.DIAGNOSTIC,
+ value=lambda api, ch: api.ptz_tilt_position(ch),
+ supported=lambda api, ch: api.supported(ch, "ptz_tilt_position"),
),
ReolinkSensorEntityDescription(
key="battery_percent",
diff --git a/homeassistant/components/reolink/strings.json b/homeassistant/components/reolink/strings.json
index 67fd5329e14..fbc88ed1b50 100644
--- a/homeassistant/components/reolink/strings.json
+++ b/homeassistant/components/reolink/strings.json
@@ -649,6 +649,9 @@
"ptz_pan_position": {
"name": "PTZ pan position"
},
+ "ptz_tilt_position": {
+ "name": "PTZ tilt position"
+ },
"battery_temperature": {
"name": "Battery temperature"
},
diff --git a/tests/components/reolink/snapshots/test_diagnostics.ambr b/tests/components/reolink/snapshots/test_diagnostics.ambr
index 33e9c78c550..71c5397fbd1 100644
--- a/tests/components/reolink/snapshots/test_diagnostics.ambr
+++ b/tests/components/reolink/snapshots/test_diagnostics.ambr
@@ -118,8 +118,8 @@
'null': 2,
}),
'GetPtzCurPos': dict({
- '0': 1,
- 'null': 1,
+ '0': 2,
+ 'null': 2,
}),
'GetPtzGuard': dict({
'0': 2,
--
GitLab