From 36cbd28d9d4e6e6df15882bca2e732cac0e0e929 Mon Sep 17 00:00:00 2001
From: Jan Bouwhuis <jbouwh@users.noreply.github.com>
Date: Tue, 11 Mar 2025 17:41:19 +0100
Subject: [PATCH] Add platinum quality scale to incomfort integration (#136387)
* Add platinum quality scale to incomfort integration
* Add platinum quality scale to incomfort integration
* Exempt actions attributes
* Comment on known limitations
---
.../components/incomfort/manifest.json | 1 +
.../components/incomfort/quality_scale.yaml | 77 +++++++++++++++++++
script/hassfest/quality_scale.py | 2 -
3 files changed, 78 insertions(+), 2 deletions(-)
create mode 100644 homeassistant/components/incomfort/quality_scale.yaml
diff --git a/homeassistant/components/incomfort/manifest.json b/homeassistant/components/incomfort/manifest.json
index d02b1d27554..825f198dd30 100644
--- a/homeassistant/components/incomfort/manifest.json
+++ b/homeassistant/components/incomfort/manifest.json
@@ -10,5 +10,6 @@
"documentation": "https://www.home-assistant.io/integrations/incomfort",
"iot_class": "local_polling",
"loggers": ["incomfortclient"],
+ "quality_scale": "platinum",
"requirements": ["incomfort-client==0.6.7"]
}
diff --git a/homeassistant/components/incomfort/quality_scale.yaml b/homeassistant/components/incomfort/quality_scale.yaml
new file mode 100644
index 00000000000..f5af3c9d061
--- /dev/null
+++ b/homeassistant/components/incomfort/quality_scale.yaml
@@ -0,0 +1,77 @@
+rules:
+ # Bronze
+ action-setup:
+ status: exempt
+ comment: |
+ No actions implemented.
+ appropriate-polling: done
+ brands: done
+ common-modules: done
+ config-flow-test-coverage: done
+ config-flow: done
+ dependency-transparency: done
+ docs-actions:
+ status: exempt
+ comment: |
+ No actions implemented.
+ docs-high-level-description: done
+ docs-installation-instructions: done
+ docs-removal-instructions: done
+ entity-event-setup:
+ status: done
+ comment: |
+ Entities are set up dand updated through the datacoordimator.
+ entity-unique-id: done
+ has-entity-name: done
+ runtime-data: done
+ test-before-configure: done
+ test-before-setup: done
+ unique-config-entry: done
+ # Silver
+ config-entry-unloading: done
+ log-when-unavailable: done
+ entity-unavailable: done
+ action-exceptions: done
+ reauthentication-flow: done
+ parallel-updates: done
+ test-coverage: done
+ integration-owner: done
+ docs-installation-parameters: done
+ docs-configuration-parameters: done
+
+ # Gold
+ entity-translations: done
+ entity-device-class: done
+ devices: done
+ entity-category: done
+ entity-disabled-by-default: done
+ discovery: done
+ stale-devices:
+ status: exempt
+ comment: >
+ There is a maximum of 3 heaters that can be discovered by the gateway.
+ The user must remove manually any heeater devices that have been replaced.
+ diagnostics: done
+ exception-translations: done
+ icon-translations: done
+ reconfiguration-flow: done
+ dynamic-devices: done
+ discovery-update-info: done
+ repair-issues:
+ status: exempt
+ comment: |
+ No current issues to repair.
+ docs-use-cases: done
+ docs-supported-devices: done
+ docs-supported-functions: done
+ docs-data-update: done
+ docs-known-limitations:
+ status: done
+ comment: There are no known limmitations,
+ docs-troubleshooting: done
+ docs-examples: done
+
+ # Platinum
+ async-dependency: done
+ inject-websession: done
+ strict-typing: done
diff --git a/script/hassfest/quality_scale.py b/script/hassfest/quality_scale.py
index 65e9d4ed9cc..e1898afc79b 100644
--- a/script/hassfest/quality_scale.py
+++ b/script/hassfest/quality_scale.py
@@ -515,7 +515,6 @@ INTEGRATIONS_WITHOUT_QUALITY_SCALE_FILE = [
"ihc",
"imgw_pib",
"improv_ble",
- "incomfort",
"influxdb",
"inkbird",
"insteon",
@@ -1579,7 +1578,6 @@ INTEGRATIONS_WITHOUT_SCALE = [
"imap",
"imgw_pib",
"improv_ble",
- "incomfort",
"influxdb",
"inkbird",
"insteon",
--
GitLab