From 3537a7c3d5b639baf8656393b0ca25134cdedb7b Mon Sep 17 00:00:00 2001
From: Martin Hjelmare <marhje52@gmail.com>
Date: Wed, 13 Jan 2021 15:31:31 +0100
Subject: [PATCH] Correct zwave_js value changed callback signature (#45110)
---
.coveragerc | 1 -
homeassistant/components/zwave_js/entity.py | 7 ++-----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/.coveragerc b/.coveragerc
index a8f198d436c..d57ffe39217 100644
--- a/.coveragerc
+++ b/.coveragerc
@@ -1091,7 +1091,6 @@ omit =
homeassistant/components/supla/*
homeassistant/components/zwave/util.py
homeassistant/components/zwave_js/discovery.py
- homeassistant/components/zwave_js/entity.py
homeassistant/components/zwave_js/light.py
homeassistant/components/zwave_js/sensor.py
diff --git a/homeassistant/components/zwave_js/entity.py b/homeassistant/components/zwave_js/entity.py
index 70630cbd89c..5bc1e477523 100644
--- a/homeassistant/components/zwave_js/entity.py
+++ b/homeassistant/components/zwave_js/entity.py
@@ -83,15 +83,12 @@ class ZWaveBaseEntity(Entity):
return self.client.connected and bool(self.info.node.ready)
@callback
- def _value_changed(self, event_data: Union[dict, ZwaveValue]) -> None:
+ def _value_changed(self, event_data: dict) -> None:
"""Call when (one of) our watched values changes.
Should not be overridden by subclasses.
"""
- if isinstance(event_data, ZwaveValue):
- value_id = event_data.value_id
- else:
- value_id = event_data["value"].value_id
+ value_id = event_data["value"].value_id
if value_id not in self.watched_value_ids:
return
--
GitLab