From 036e99e91e9b407dbed377a4a51c8cc21bad71e9 Mon Sep 17 00:00:00 2001
From: Raman Gupta <7243222+raman325@users.noreply.github.com>
Date: Fri, 20 Aug 2021 00:43:04 -0400
Subject: [PATCH] Allow integrations to define trigger platforms with a subtype
(#54861)
---
homeassistant/helpers/trigger.py | 3 ++-
tests/helpers/test_trigger.py | 16 +++++++++++++++-
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/homeassistant/helpers/trigger.py b/homeassistant/helpers/trigger.py
index b5a82c3c020..29f344a6fa0 100644
--- a/homeassistant/helpers/trigger.py
+++ b/homeassistant/helpers/trigger.py
@@ -21,7 +21,8 @@ _PLATFORM_ALIASES = {
async def _async_get_trigger_platform(hass: HomeAssistant, config: ConfigType) -> Any:
- platform = config[CONF_PLATFORM]
+ platform_and_sub_type = config[CONF_PLATFORM].split(".")
+ platform = platform_and_sub_type[0]
for alias, triggers in _PLATFORM_ALIASES.items():
if platform in triggers:
platform = alias
diff --git a/tests/helpers/test_trigger.py b/tests/helpers/test_trigger.py
index b4bfb881186..7afdb629792 100644
--- a/tests/helpers/test_trigger.py
+++ b/tests/helpers/test_trigger.py
@@ -1,8 +1,13 @@
"""The tests for the trigger helper."""
+from unittest.mock import MagicMock, call, patch
+
import pytest
import voluptuous as vol
-from homeassistant.helpers.trigger import async_validate_trigger_config
+from homeassistant.helpers.trigger import (
+ _async_get_trigger_platform,
+ async_validate_trigger_config,
+)
async def test_bad_trigger_platform(hass):
@@ -10,3 +15,12 @@ async def test_bad_trigger_platform(hass):
with pytest.raises(vol.Invalid) as ex:
await async_validate_trigger_config(hass, [{"platform": "not_a_platform"}])
assert "Invalid platform 'not_a_platform' specified" in str(ex)
+
+
+async def test_trigger_subtype(hass):
+ """Test trigger subtypes."""
+ with patch(
+ "homeassistant.helpers.trigger.async_get_integration", return_value=MagicMock()
+ ) as integration_mock:
+ await _async_get_trigger_platform(hass, {"platform": "test.subtype"})
+ assert integration_mock.call_args == call(hass, "test")
--
GitLab